Skip to content

Conversation

@enumag
Copy link
Contributor

@enumag enumag commented Dec 9, 2022

No description provided.

@enumag
Copy link
Contributor Author

enumag commented Dec 10, 2022

The test failures are unrelated to my patch.

@enumag
Copy link
Contributor Author

enumag commented Dec 12, 2022

@ondrejmirtes Can you merge this please? Because of the current impossibility to override a stub on my side it's currently kinda blocking me.

@ondrejmirtes ondrejmirtes merged commit 7231478 into phpstan:1.3.x Dec 12, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@enumag
Copy link
Contributor Author

enumag commented Dec 12, 2022

Thanks!

@stof
Copy link
Contributor

stof commented Dec 12, 2022

This breaks things when using INDEX BY in DQL, as the result is not a list in such case. Returning a list is something that needs to be handled by improving the type extension analysing the query, not by this broken stub

@enumag
Copy link
Contributor Author

enumag commented Dec 12, 2022

I see. Didn't know that. Alright let's revert this and handle it better.

@enumag enumag mentioned this pull request Dec 12, 2022
@VincentLanglet
Copy link
Contributor

There is the wip #384

@enumag enumag deleted the patch-1 branch December 13, 2022 07:56
@enumag
Copy link
Contributor Author

enumag commented Dec 13, 2022

@VincentLanglet That PR only handles object result while my case is for array result but it does the hard work of detecting the list result. I should be able to fix this correctly after that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants